On 10/2/2016 5:47 AM, Amrith Kumar wrote:
It was my understanding that hacking rules were like the 'Ten Commandments',
the 'Four Opens'; things that were universally true across all projects and an
attempt to bring standardization to all OpenStack code.
How come we then have extensive project specific hacking rules? Why not make these
"nova-specific" rules OpenStack wide?
I looked at the checks.py file that Matt linked to below, and I can't see anything really
"nova-specific"; i.e. all of them would translate just fine to Trove. Is there
some reason they can't become OpenStack wide rules?
-amrith
-----Original Message-----
From: Ihar Hrachyshka [mailto:ihrac...@redhat.com]
Sent: Sunday, October 02, 2016 5:25 AM
To: OpenStack Development Mailing List (not for usage questions)
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [all][i18n] do we need translation mark for
strings in tests?
Matt Riedemann <mrie...@linux.vnet.ibm.com> wrote:
On 10/1/2016 5:49 PM, Matt Riedemann wrote:
No you shouldn't need to mark strings for translation in test code. I
believe we have a hacking rule for marking LOG.info/warning/error
messages for translation but it should skip test directories.
Ah I guess the hacking rule is nova-specific:
https://github.com/openstack/nova/blob/2851ceaed3010c19f42e308be637b952eda
b092a/nova/hacking/checks.py#L342
We have a similar one in neutron; but note that it does not explicitly
FAIL
on translation markers in test code; it instead fails on no markers in
production code, which is different different.
Ihar
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Well for one thing the specific one I pointed out has hard-coded nova
paths in it which might not work for other projects.
--
Thanks,
Matt Riedemann
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
