On Mon, Aug 1, 2016 at 4:00 PM, James E. Blair <cor...@inaugust.com> wrote: > Masayuki Igawa <masayuki.ig...@gmail.com> writes: > >> Hi! >> >> On Wed, Jul 27, 2016 at 11:50 PM, James E. Blair <cor...@inaugust.com> wrote: >>> Michał Dulko <michal.du...@intel.com> writes: >>> >>>> Just wondering - were there tries to implement syntax highlighting in >>>> diff view? I think that's the only thing that keeps me from switching to >>>> Gertty. >>> >>> I don't know of anyone working on that, but I suspect it could be done >>> using the pygments library. >> >> Oh, it's an interesting feature to me :) I'll try to investigate and >> implement in next couple of days :) > > As I think about this, one challenge in particular comes to mind: Gerrit > uses background color (green and pink) to distinguish old and new > text when displaying diffs. In Gertty, I avoided that and used > foreground colors instead because text with green and red backgrounds is > difficult to read on a terminal. > > We essentially have two channels of information that we want to > represent with color -- the diff, and the syntax. They can sometimes > overlap. > > Perhaps we could use a 256 color (or even RGB) terminal for this > feature. Then we may be able to get just the right shade of background > color for the diff channel, and use the foreground colors for syntax > highlighting. > > At any rate, it may be worth trying to solve *this* problem first with a > mockup to see if there is any way of doing this without making our eyes > bleed before working on the code to implement it.
In theory it is possible split diff and syntax spatially, so there would be no need to mix diff and syntax colors. Mockup http://i.imgur.com/gAD9x9v.png > > -Jim > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
