On Wed, Jun 22, 2016 at 03:23:43PM +1000, Tony Breeds wrote: > On Wed, Jun 22, 2016 at 06:45:31AM +0200, Haïkel wrote: > > Hi, > > > > as a packager, I spend a lot of time to scrutinize the requirements > > repo, and I find it easier to read if specifiers are ordered. > > So in a quick glance, you can check which is the min version required > > and max one without trying to search them among other specifiers. > > I scripted a basic linter to do that (which also normalize comments to > > PEP8 standards) > > > > Initial review is here: > > https://review.openstack.org/#/c/332623/ > > > > script is available here; > > https://gist.github.com/hguemar/7a17bf93f6c8bd8ae5ec34bf9ab311a1 > > > > Your thoughts? > > I'm fine with doign something like this. I wrote [1] some time ago but didn't > push on it as I needed to verify that this wouldn't create a "storm" of > pointless updates that just reorder things in every projects > *requirements.txt.
I think we need to pause on these 'normalizing' changes in g-r. They're genertaing whitspace only reviews in many, (possibly all) projects that have managed requirements. We need to do more testing and possibly make the bot smarter befoer we look at this again. Yours Tony.
signature.asc
Description: PGP signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
