I agree with your approach Jeffrey, although this is not ideal, this is an approach already used in kolla.
2016-05-04 12:01 GMT-03:00 Jeffrey Zhang <zhang.lei....@gmail.com>: > Recently, Jack Ning pushed a PS[0], which export the `WEBROOT` to the > globals.yml file. > Because there is no chance to change the horizon/apache configure file now. > > The root cause is that: Kolla do not support non-ini format configure > file. for the > ini-format file, we use a merge_config module[1] to merge all the found > file. But it > will be not work for configure file for apache, rabbitmq and so on. > > I would like to the current merge_config implementation. It is directly > and easy to use. > Not like the puppet, we have to remember the variable name defined in the > module. we have > no chance to add some user-defined variable. > > Export the variable to global is very bad and ugly. It will became a > disaster when more > and more variables is exported. > > So we should catch up a better solution to handle the configure file. > > One solution I have is use overwrite mechanism. for example when there is > a file in > /etc/kolla/config/apache.conf, it will overwrite the templates in the > roles. But this > is still not ideal. > > Any body has better solution? > > [0] https://review.openstack.org/306928 > [1] > http://git.openstack.org/cgit/openstack/kolla/tree/ansible/action_plugins/merge_configs.py > > -- > Regards, > Jeffrey Zhang > Blog: http://xcodest.me > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
