Yes, It would be better to avoid the field name duplicated with DB key words. 
These tables are ported from Nova and Neutron, it would be good to change the 
field name.

Best Regards
Chaoyi Huang ( Joe Huang )


-----Original Message-----
From: Shinobu Kinjo [mailto:shinobu...@gmail.com] 
Sent: Saturday, March 26, 2016 2:39 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [openstack-dev] [Tricircle] Using the reserved keywords reserved as 
field name

Hi Team,

In the Tricircle database, there are three tables having a field name which the 
MySQL (MariaDB) has as one of the reserved keywords. [1]

 Table Name:
  aggregate_metadata
  instance_type_extra_specs
  quality_of_service_specs

 Field Name:
  key

I think it would not be best practice to use any reserved word by the any 
system because it could cause bug once the component is bigger.

What do you think?

[1] http://dev.mysql.com/doc/refman/5.0/en/keywords.html

Cheers,
Shinobu

--
Email:
shin...@linux.com
GitHub:
shinobu-x
Blog:
Life with Distributed Computational System based on OpenSource

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to