My 2 cents, I agree that it is low risk -- the impl for resume is analogous/parallel to the impl for suspend. And, it makes little sense to me to include suspend without resume.
In my mind, these two operations are halves of the same feature, and since it is already partially implemented and approved, I the FFE should be granted. Best, Trev On Mon, 2016-03-07 at 09:07 -0500, Trevor McKay wrote: > For some reason the link below is wrong for me, it goes to a different > review. Here is a good one (I hope!): > > https://review.openstack.org/#/c/285839/ > > Trev > > On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote: > > Hi folks, > > > > I would like to request a FFE for the feature “Resume EDP job”: > > > > > > > > BP: > > https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs > > > > > > Spec has been merged. https://review.openstack.org/#/c/198264/ > > > > > > Suspend EDP patch has been merged. > > https://review.openstack.org/#/c/201448/ > > > > > > Code Review: https://review.openstack.org/#/c/285839/ > > > > > > > > code is ready for review. > > > > > > > > The Benefits for this change: after suspend job, we can resume this > > job. > > > > > > > > The Risk: The risk would be low for this patch, since the code of > > suspend patch has been long time reviewed. > > > > > > > > Thanks, > > > > luhuichun > > > > > > > > __________________________________________________________________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
