Breakage of anything is probably the last thing I intended to achieve with that patch. Maybe I misunderstand how tasks dependencies works, let me describe *explicit* dependencies I did in tasks.yaml:
hiera requires deploy_start hiera is required for setup_repositories setup_repositories is required for fuel_pkgs setup_repositories requires hiera fuel_pkgs requires setup_repositories fuel_pkgs is required globals Coming from packaging realm, there is clear transitive dependency for anything that pulls globals task, i.e. if task foo depends on globals, the latter pulls fuel_pkgs, which brings setup_repositories in. I'm in favor of reverting both patches (master and stable/8.0) if it's going to break backwards compatibility, but I really see bigger problem in the way we handle task dependencies. Bartłomiej On Thu, Jan 21, 2016 at 9:51 AM, Swann Croiset <scroi...@mirantis.com> wrote: > Sergii, > I'm also curious, what about plugins which intend to be compatible with > both MOS 7 and MOS 8? > I've in mind the LMA plugins stable/0.8 > > BR > > -- > Swann > > On Wed, Jan 20, 2016 at 8:34 PM, Sergii Golovatiuk < > sgolovat...@mirantis.com> wrote: > >> Plugin master branch won't be compatible with older versions. Though the >> plugin developer may create stable branch to have compatibility with older >> versions. >> >> >> -- >> Best regards, >> Sergii Golovatiuk, >> Skype #golserge >> IRC #holser >> >> On Wed, Jan 20, 2016 at 6:41 PM, Dmitry Mescheryakov < >> dmescherya...@mirantis.com> wrote: >> >>> Sergii, >>> >>> I am curious - does it mean that the plugins will stop working with >>> older versions of Fuel? >>> >>> Thanks, >>> >>> Dmitry >>> >>> 2016-01-20 19:58 GMT+03:00 Sergii Golovatiuk <sgolovat...@mirantis.com>: >>> >>>> Hi, >>>> >>>> Recently I merged the change to master and 8.0 that moves one task from >>>> Nailgun to Library [1]. Actually, it replaces [2] to allow operator more >>>> flexibility with repository management. However, it affects the detached >>>> components as they will require one more task to add as written at [3]. >>>> Please adapt your plugin accordingly. >>>> >>>> [1] >>>> https://review.openstack.org/#/q/I1b83e3bfaebecdb8455d5697e320f24fb4941536 >>>> [2] >>>> https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/orchestrator/tasks_serializer.py#L149-L190 >>>> [3] https://review.openstack.org/#/c/270232/1/deployment_tasks.yaml >>>> >>>> -- >>>> Best regards, >>>> Sergii Golovatiuk, >>>> Skype #golserge >>>> IRC #holser >>>> >>>> >>>> __________________________________________________________________________ >>>> OpenStack Development Mailing List (not for usage questions) >>>> Unsubscribe: >>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>>> >>>> >>> >>> >>> __________________________________________________________________________ >>> OpenStack Development Mailing List (not for usage questions) >>> Unsubscribe: >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> >>> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
