Nastya,
according to the template I provided initially [1] format in fuel-qa is
invalid. I've requested to support only one format [2].
File must always have a folder. If you want to cover the whole repo, then
the right structure would be
maintainers:
- ./:
- name: ...
email: ...
IRC: ...
e.g. you'd just refer to the current folder, which should be root of the
repo by default.
Simon is asking a valid request: if you add his folder in the file, he will
be always added to the review request by script, once it's implemented.
Only in the case when contribution is made to his particular area of
responsibility.
[1] https://github.com/openstack/fuel-web/blob/master/MAINTAINERS
[2] https://bugs.launchpad.net/fuel/+bug/1497655
On Tue, Oct 20, 2015 at 11:03 PM Anastasia Urlapova <aurlap...@mirantis.com>
wrote:
> Simon,
> structure of fuel-web repo is much more complex than fuel-qa, ~ 50 active
> contributors work with fuel-web.
> There is the functionality of the different Fuel domains and each requires
> its own expertise, so maintenance is divided by folders.
> In case of fuel-qa maintainers are doing review for whole repository,
> structure of file[0] is correct.
>
>
> Nastya.
> [0] https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS
>
> On Wed, Oct 21, 2015 at 2:15 AM, Mike Scherbakov <mscherba...@mirantis.com
> > wrote:
>
>> Simon,
>> I believe that it's a mistake in fuel-qa. Valid structure is in fuel-web.
>> Please fix the one in fuel-qa.
>>
>> I'm also looking forward for automated adding of people to review
>> requests based on this file. Here is the task to track it:
>> https://bugs.launchpad.net/fuel/+bug/1497655
>>
>> On Tue, Oct 20, 2015 at 2:10 AM Simon Pasquier <spasqu...@mirantis.com>
>> wrote:
>>
>>> Thanks for the reply, Andrew! I must admit that I haven't read
>>> thoroughly the specification on the new team structure [1]. IIUC plugin
>>> developers should be added to the MAINTAINERS file of fuel-qa for the
>>> directories that concern their plugins. If I take LMA as an example, this
>>> would be:
>>> fuelweb_test/tests/plugins/plugin_elasticsearch
>>> fuelweb_test/tests/plugins/plugin_lma_collector
>>> fuelweb_test/tests/plugins/plugin_lma_infra_alerting
>>>
>>> Is that right?
>>>
>>> I can submit a change to fuel-qa for adding the LMA team to the
>>> MAINTAINERS file but I can't figure out the structure of the YAML data:
>>> fuel-web/MAINTAINERS [2] is organized as "{directory1: [maintainer1,
>>> maintainer2, ...], directory2: [...], ...}" while for fuel-qa [3] (and
>>> other Fuel projects), it's "[maintainer1, maintainer2, ...]".
>>>
>>> BR,
>>> Simon
>>>
>>> [1]
>>> http://specs.fuel-infra.org/fuel-specs-master/policy/team-structure.html
>>> [2] https://github.com/openstack/fuel-web/blob/master/MAINTAINERS
>>> [3] https://github.com/openstack/fuel-qa/blob/master/MAINTAINERS
>>>
>>>
>>> On Sat, Oct 17, 2015 at 2:21 AM, Andrew Woodward <xar...@gmail.com>
>>> wrote:
>>>
>>>> We have already discussed this to be a result of describing data driven
>>>> testing, untill this spec is completed there is little sense to remove all
>>>> of these since fuel-qa is 100% required to operate this way. In the interim
>>>> we should just specify the appropriate SME with the MAINTAINERS file.
>>>>
>>>> On Fri, Oct 16, 2015 at 11:34 AM Sergii Golovatiuk <
>>>> sgolovat...@mirantis.com> wrote:
>>>>
>>>>> Tests should be in plugin
>>>>>
>>>>> --
>>>>> Best regards,
>>>>> Sergii Golovatiuk,
>>>>> Skype #golserge
>>>>> IRC #holser
>>>>>
>>>>> On Fri, Oct 16, 2015 at 5:58 PM, Simon Pasquier <
>>>>> spasqu...@mirantis.com> wrote:
>>>>>
>>>>>> Hello Alexey,
>>>>>>
>>>>>> On Fri, Oct 16, 2015 at 5:35 PM, Alexey Elagin <aela...@mirantis.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hello Simon!
>>>>>>>
>>>>>>> We are going to remove plugins' functional tests from fuel-qa
>>>>>>> because this tests don't use for our plugins CI process.
>>>>>>>
>>>>>>
>>>>>> And where are the existing tests going to be stored then?
>>>>>>
>>>>>> Thanks,
>>>>>> Simon
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> __________________________________________________________________________
>>>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>>>> Unsubscribe:
>>>>>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> __________________________________________________________________________
>>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>>> Unsubscribe:
>>>>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>>
>>>>>>
>>>>>
>>>>> __________________________________________________________________________
>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>> Unsubscribe:
>>>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>
>>>> --
>>>>
>>>> --
>>>>
>>>> Andrew Woodward
>>>>
>>>> Mirantis
>>>>
>>>> Fuel Community Ambassador
>>>>
>>>> Ceph Community
>>>>
>>>>
>>>> __________________________________________________________________________
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe:
>>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>
>>>>
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>> --
>> Mike Scherbakov
>> #mihgen
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
--
Mike Scherbakov
#mihgen
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
