On 10/05/2015 12:12 PM, Jeremy Stanley wrote: > On 2015-10-05 12:00:31 -0500 (-0500), Ben Nemec wrote: > [...] >> Note that it's best to do this once the change is ready to be >> approved. If you do it earlier and the committer pushes a new >> patch set without fixing the commit message, it will revert the >> fix made through the web interface. > > Well, one workflow tweak which avoids that is to always pull the > latest state of your change from Gerrit before you start modifying > it rather than assuming what is in your filesystem is still current. > It also helps to check Gerrit before pushing a new patchset (or lurk > in an IRC channel where the openstackgerrit bot reports uploads for > that repo), making sure nobody else has updated that change while > you were editing. > > That said, a lot of developers probably don't do this. >
Yeah, and I'm assuming we shouldn't need to fix commit messages much for experienced developers who know to do this, but maybe I'm being optimistic there. :-) __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
