On 09/24/2015 05:16 PM, Jeremy Stanley wrote: > On 2015-09-24 14:39:49 -0500 (-0500), Alex Schultz wrote: > [...] >> Being able to run tests without internet connectivity is important to >> some people so I want to make sure that can continue without having to >> break the process mid-cycle to try and inject a workaround. It would >> better if we could have a workaround upfront. For example make a >> Puppetfile location an environment variable and if not defined pull >> down the puppet-openstack-integration one? I wish there was a better >> dependency resolution method that just pulling everything down from >> the internets. I just know that doesn't work everywhere. > > To build on Clark's response, THIS is basically why we use tools > like zuul-cloner. In our CI we're attempting to minimize or even > eliminate network use during tests, and so zuul-cloner leverages > local caches and is sufficiently flexible to obtain the repositories > in question from anywhere you want (which could also just be to > always use your locally cached/modified copy and never hit the > network at all). Pass it whatever Git repository URLs you want, > including file:///some/thing.git if that's your preference. >
So we had a discussion on #puppet-openstack channel, and Alex's main concern was people should be able to continue to be able to edit a file (it was .fixtures.yaml, it will be a Puppetfile now) to run tests against custom dependencies (modules + version can be whatever you like). It has been addressed in the last patchset: https://review.openstack.org/#/c/226830/21..22/Rakefile,cm So in your care, you'll have to: 1/ Build your Puppetfile that contains your custom deps (instead of editing the .fixtures.yaml) 2/ Export PUPPETFILE=/path/Puppetfile 3/ Run `rake rspec` like before. This solution should make happy everyone: * Default usage (on my laptop) will test the same things as Puppet OpenStack CI * Allow to use Depends-On in OpenStack CI * Allow to customize the dependencies for downstream CI by creating a Puppetfile and exporting its path. Deal? -- Emilien Macchi
signature.asc
Description: OpenPGP digital signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
