Thanks, I learned a thing or two from the document that you linked. Thanks for reminding us of that.
Carl On Tue, Sep 1, 2015 at 3:14 AM, Ihar Hrachyshka <ihrac...@redhat.com> wrote: > Hi reviewers, > > several days ago, a semantically expand-only migration script was merged into > contract branch [1]. This is not a disaster, though it would be a tiny one if > a contract-only migration script would be merged into expand branch. > > Please make sure you know the new migration strategy described in [2]. > > Previously, we introduced a check that validates that we don’t mix > down_revision heads, linking e.g. expand script to contract revision, or vice > versa [3]. Apparently, it’s not enough. > > Ann is looking into introducing another check for semantical correctness of > scripts. I don’t believe it may work for all complex cases we may need to > solve manually, but at least it should be able to catch add_* operations in > contract scripts, or drop_* operations in expand branch. Since there may be > exceptions to general automation, we may also need a mechanism to disable > such a sanity check for specific scripts. > > So all in all, I kindly ask everyone to become aware of how we now manage > migration scripts, and what it implies in how we should review code (f.e. > looking at paths as well as the code of alembic scripts). That is especially > important before the test that Ann is looking to implement is not merged. > > [1]: https://bugs.launchpad.net/neutron/+bug/1490767 > [2]: > http://docs.openstack.org/developer/neutron/devref/alembic_migrations.html > [3]: https://review.openstack.org/#/c/206746/ > > Thanks > Ihar > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
