Hi,
although rdomanager-oscplugin is not yet under TripleO it should be
soon, so sending this to TripleO audience.
Satellite registration from user's point of view is now done by passing
couple of specific parameters when running "openstack overcloud deploy"
command [1]. rdomanager-oscplugin checks presence of these params and
adds additional env files which are then passed to heat and it also
generates a temporary env file containing default_params required for
rhe-registration template [2].
This approach is not optimal because it means that:
a) registration params have to be passed on each call of "openstack
overcloud deploy"
b) other CLI commands (pkg update, node deletion) should implement/reuse
the same logic (support same parameters) to be consistent
This is probably not necessary because registration params should be
needed only when creating OC stack, no need to pass them later when
running any update operation.
As a short term solution I think it would be better to pass registration
templates in the same way as other extra files ("-e" param) - although
user will still have to pass additional parameter when using
rhel-registration, it will be consistent with the way how e.g. network
configuration is used and the "-e" mechanism for passing additional env
files is already supported in other CLI commands.
"_create_registration_env" method [2] would be updated to generate&add
just user's credentials [3] env file - and this would be needed only
when creating overcloud, no need to pass them when updating stack later.
If there are no objections/feedback, I'll send a patch (and of course
update documentation too) which updates CLI as described above.
Jan
[1]
https://repos.fedorapeople.org/repos/openstack-m/docs/master/basic_deployment/basic_deployment_cli.html
[2]
https://github.com/rdo-management/python-rdomanager-oscplugin/blob/master/rdomanager_oscplugin/v1/overcloud_deploy.py#L366
[3]
https://github.com/rdo-management/python-rdomanager-oscplugin/blob/master/rdomanager_oscplugin/v1/overcloud_deploy.py#L378
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
