I gave it some thought, and came to a conclusion, that adopting openstack config is the right thing to do. It enables some of the rules, that are disabled by default, so it actually is stricter, than our current config. So https://review.openstack.org/#/c/206729/
Thank you again for your work Michael! -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 28 Jul 2015 at 17:38:03, Michael Krotscheck (krotsch...@gmail.com) wrote: Well, the reasons those rules are deactivated is because they simply had no equivalent in the previous tool, and we didn't want to force the Horizon team to suddenly take on a far more aggressive style correction job than they'd signed up for. Once their job goes green, I'm going to start updating those rules one by one to slowly tighten the rules set. With that in mind though: You can always extend the openstack rules and add your own additional restrictions. So: Best of both worlds :), just make sure you keep track of what's coming in from upstream. Michael On Tue, Jul 28, 2015 at 3:58 AM Kirill Zaitsev <kzait...@mirantis.com> wrote: Thanks Michael, I’m actually watching this process closely, and considering switching to these rules, as soon as the job goes green. =) The upside of not doing so is that, since our (murano) js code base is significantly smaller than that of horizon — we can impose slightly stricter rule set, than horizon currently does. But switching to it completely is something, that I do consider and it is on the roadmap =) -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 28 Jul 2015 at 03:00:40, Michael Krotscheck (krotsch...@gmail.com) wrote: FYI, those rules have been moved into OpenStack under the QA program. I'm currently working on getting npm publish jobs to function so we can release those rules as well. http://git.openstack.org/cgit/openstack/eslint-config-openstack/ Michael On Mon, Jul 27, 2015 at 4:13 PM Kirill Zaitsev <kzait...@mirantis.com> wrote: Since there was some interest in my side activity (which is described in https://blueprints.launchpad.net/murano/+spec/add-js-lint-jobs) I’ve created an etherpad with files, that are yet to be cleaned up. Here is the link https://etherpad.openstack.org/p/murano-escleanup So I suggest, that if you’re willing to help — add yourself in front of the file you’d like to cleanup so that we would not do the same job twice. When adding rule configs I try to refer to https://github.com/krotscheck/eslint-config-openstack/blob/master/.eslintrc (I’m considering switching to it completely, but that is a story for a different letter =)) -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
