Hi folks, Andrew, the code looks safe to me and the only question I have what the point of this patch if it's unused? I mean the generators? Until you use them in cluster attributes (openstack.yaml) new generators are useless, and don't fix anything.
Are you going to use them in 7.0 to fix some Ceph bugs or what? Thanks, Igor On Mon, Jul 27, 2015 at 9:25 AM, Sebastian Kalinowski <skalinow...@mirantis.com> wrote: > Andrew, thanks for this request and for the explanations. > > +1 for this exception. The new generators are not conflicting with existing > ones, code is ready and tested so let's merge it. > > 2015-07-25 1:24 GMT+02:00 Andrew Woodward <xar...@gmail.com>: >> >> I'm writing to ask for a FFE for landing the ceph generators. It finally >> received core-reviewers attention late on Wednesday and Thursday and is >> ready to merge now. I'm only asking for FFE because reviewers are calling >> this a feature. >> >> Possible impact, none. This is not used by anything yet and should be >> merged. >> >> [1] https://bugs.launchpad.net/fuel/+bug/1475759 >> [2] https://review.openstack.org/#/c/203270/ >> -- >> >> -- >> >> Andrew Woodward >> >> Mirantis >> >> Fuel Community Ambassador >> >> Ceph Community >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
