Thai - I thought there was a conscious decision to separate addressing the JSCS issues and applying JP's guidelines. Smaller more precise patches are easier to land! I plan on applying JP's guidelines in a follow on patch. Especially since one of my JSCS patches merged this morning.
Aaron D. Sahlin IBMUSM07(asahlin) Dept. X2WA Phone 507-253-7349 Tie 553-7349 From: Thai Q Tran/Silicon Valley/IBM@IBMUS To: "OpenStack Development Mailing List \(not for usage questions\)" <openstack-dev@lists.openstack.org> Date: 06/04/2015 01:33 PM Subject: [openstack-dev] [horizon] Prioritize tests over JSCS Hi folks, I know a lot of people are tackling the JSCS stuff, and thats really great. But it would be extra nice to see JSCS stuff along with JP's guidelines in your patches. Furthermore, if the file you are working on doesn't have an accompanying spec file, please make sure that the tests for it exists. If it is not there, please prioritize and spend some time reviewing patches with the tests you need, or create a spec file and get that merge first. Thanks __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
