Hi, Sometime back we had a discussion on IRC regarding sqlite migration scripts. Since sqlite is mostly used for testing, we were thinking about moving the sqlite migration related code to tests folder and keep the migrate_repo sane (with only production code). There was utility class[1] added recently for helping with sqlite migrations and there were questions on the location of that class. The utility lives in heat/db/sqlalchemy folder and since it is used only for testing, it should probably live somewhere in the tests folder (like tests/migrate_repo? ) along with the sqlite migration scripts.
It would be better if we have a separate path for testing code and depending on the configured DB back-end (for example, sqlite), we pass the appropriate path (something like tests/migrate_repo for sqlite) to oslo_migration.db_sync(). If it is okay to assume that sqlite is *always* used for testing, then IMO, we should re-factor the migration scripts. Please help us with your thoughts. [1] https://github.com/openstack/heat/blob/master/heat/db/sqlalchemy/utils.py - Anant __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
