Marcus,

Don’t turn off ci, because then you could miss another regression.

Instead, simply exclude that test case:
e.g.
export 
DEVSTACK_GATE_TEMPEST_REGEX="^(?=.*tempest.api.volume)(?!.*test_snapshots_actions).*"

Ramy


From: Marcus Vinícius Ramires do Nascimento [mailto:marcus...@gmail.com]
Sent: Wednesday, March 04, 2015 1:29 PM
To: openstack-dev@lists.openstack.org; Announcements for third party CI 
operators.
Subject: [openstack-dev] [cinder] [Third-party-announce] Cinder Merged patch 
broke HDS driver

Hi folks,

This weekend, the patch "Snapshot and volume objects" 
(https://review.openstack.org/#/c/133566) was merged and this one broke our HDS 
HBSD driver and the respective CI.

When CI tries to run tempest.api.volume.admin.test_snapshots_actions the 
following error is shown:

2015-03-04 14:00:34.368 ERROR oslo_messaging.rpc.dispatcher 
[req-c941792b-963f-4a7d-a6ac-9f1d9f823fd1 915289d113dd4f9db2f2a792c18b3564 
984bc8d228c8497689dde60dc2b8f300] Exception during messag
e handling: '<class 'cinder.objects.snapshot.Snapshot'>' object has no 
attribute 'snapshot_metadata'
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher Traceback (most 
recent call last):
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 
142, in _dispatch_and_reply
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     
executor_callback))
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 
186, in _dispatch
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     
executor_callback)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 
130, in _do_dispatch
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     result = 
func(ctxt, **new_args)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in 
wrapper
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return f(*args, 
**kwargs)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 156, in lso_inner1
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return 
lso_inner2(inst, context, snapshot, **kwargs)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 
431, in inner
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return f(*args, 
**kwargs)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 155, in lso_inner2
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return 
f(*_args, **_kwargs)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 635, in delete_snapshot
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     snapshot.save()
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 82, in 
__exit__
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     
six.reraise(self.type_, self.value, self.tb)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/manager.py", line 625, in delete_snapshot
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     
self.driver.delete_snapshot(snapshot)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in 
wrapper
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return f(*args, 
**kwargs)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/drivers/hitachi/hbsd_iscsi.py", line 314, in 
delete_snapshot
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     
self.common.delete_snapshot(snapshot)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py", line 635, in 
delete_snapshot
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     is_vvol = 
self.get_snapshot_is_vvol(snapshot)
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py", line 189, in 
get_snapshot_is_vvol
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return 
self.get_is_vvol(snapshot, 'snapshot_metadata')
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py", line 183, in 
get_is_vvol
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     return 
self.get_value(obj, name, 'type') == 'V-VOL'
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py", line 176, in 
get_value
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     if 
obj.get(name):
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher   File 
"/opt/stack/cinder/cinder/objects/base.py", line 615, in get
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher     self.__class__, 
key))
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher AttributeError: 
'<class 'cinder.objects.snapshot.Snapshot'>' object has no attribute 
'snapshot_metadata'
2015-03-04 14:00:34.368 TRACE oslo_messaging.rpc.dispatcher

Before merging the patch, the CI ran successfully on Patchset,38 
(http://177.84.241.119:10000/66/133566/38/silent/hitachi-hbsd-iscsi/17ee25e/) 
which already changed the files involved in this bug. Is it possible to CI run 
the tempest tests on Devstack with no patch (triggered by Zuul) applied? The CI 
didn't run the latest Patchset (41), because we had an infrastructure problem 
(power failures) during the weekend and the beginning of the week.

I checked the patch merged and I saw that it has changed a lot of snapshots 
files. In some files the "snapshot_metadata" was removed and replaced to 
"metadata". I think the best approach is to fix the driver, but until the bug 
is not fixed and reviewed, the Cinder CI will be offline. Could you guys give 
an extra priority for review this bug fix when I submit the patch, once it was 
working (the CI was in checking mode) before the patch merged?

Regards,
--
Marcus Vinícius Ramires do Nascimento
marcus...@gmail.com<mailto:marcus...@gmail.com>
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to