On 01/16/2015 07:39 AM, Clint Byrum wrote: > In about 24 hours we've seen 9 core +1's, one non-core +1, and only one > dissenting opinion from James himself which I think we have properly > dismissed. With my nomination counting as an additional +1, that is 10, > which is 50% of the 20 cores active the last 90 days. > > I believe this vote has carried. Please welcome James Polley to the > TripleO core reviewer team. :)
/me hands James is custodial mop and bucket Congratulations James and my condolences. :D Anita. > > Excerpts from Clint Byrum's message of 2015-01-14 10:14:45 -0800: >> Hello! It has been a while since we expanded our review team. The >> numbers aren't easy to read with recent dips caused by the summit and >> holidays. However, I believe James has demonstrated superb review skills >> and a commitment to the project that shows broad awareness of the >> project. >> >> Below are the results of a meta-review I did, selecting recent reviews >> by James with comments and a final score. I didn't find any reviews by >> James that I objected to. >> >> https://review.openstack.org/#/c/133554/ -- Took charge and provided >> valuable feedback. +2 >> https://review.openstack.org/#/c/114360/ -- Good -1 asking for better >> commit message and then timely follow-up +1 with positive comments for >> more improvement. +2 >> https://review.openstack.org/#/c/138947/ -- Simpler review, +1'd on Dec. >> 19 and no follow-up since. Allowing 2 weeks for holiday vacation, this >> is only really about 7 - 10 working days and acceptable. +2 >> https://review.openstack.org/#/c/146731/ -- Very thoughtful -1 review of >> recent change with alternatives to the approach submitted as patches. >> https://review.openstack.org/#/c/139876/ -- Simpler review, +1'd in >> agreement with everyone else. +1 >> https://review.openstack.org/#/c/142621/ -- Thoughtful +1 with >> consideration for other reviewers. +2 >> https://review.openstack.org/#/c/113983/ -- Thorough spec review with >> grammar pedantry noted as something that would not prevent a positive >> review score. +2 >> >> All current tripleo-core members are invited to vote at this time. Thank >> you! > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
