On 12/09/2014 03:39 AM, Sean Dague wrote: > I'd like to propose that for hacking 1.0 we drop 2 groups of rules entirely. > > 1 - the entire H8* group. This doesn't function on python code, it > functions on git commit message, which makes it tough to run locally. It > also would be a reason to prevent us from not rerunning tests on commit > message changes (something we could do after the next gerrit update).
+1 I DO like something warning about commit subject length ... but maybe that should be a git-review function or something. > 2 - the entire H3* group - because of this - > https://review.openstack.org/#/c/140168/2/nova/tests/fixtures.py,cm > > A look at the H3* code shows that it's terribly complicated, and is > often full of bugs (a few bit us last week). I'd rather just delete it > and move on. +1 flake8 does the important one now - "no wildcard imports" The others are ones where I find myself dancing to meet the style more often than not. _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
