Also, how about checking for duplicated name? That it matches standard for
DNS?
> return u"{node_id}".format(node_id=instance.name.lower())
you could just "return instance.name.lower()" I believe..
On Wed, Sep 10, 2014 at 7:00 PM, Igor Kalnitsky <ikalnit...@mirantis.com>
wrote:
> Hi Dmitry,
>
> It's not as easy as you think. The node's name may be reseted during
> some of our actions. For example, if you remove node from a cluster a
> node's name will be reseted.
>
> So the idea of the blueprint [1] is to provide mechanism when you once
> set names and they will not be reseted.
>
> [1]: https://blueprints.launchpad.net/fuel/+spec/node-naming
>
> - Igor
>
> On Wed, Sep 10, 2014 at 4:19 PM, Dmitry Ukov <du...@mirantis.com> wrote:
> > Hello Fuelers,
> > I've figured out that there is a blueprint regarding node naming
> > (https://blueprints.launchpad.net/fuel/+spec/node-naming). It looks like
> > this this feature really has not been started. That being said all
> necessary
> > preparations in Nailgun code have been already done. The only thing that
> is
> > needed to be done is to enable this feature (in fact 4 lines of code).
> > --- a/nailgun/nailgun/objects/node.py
> > +++ b/nailgun/nailgun/objects/node.py
> > @@ -654,7 +654,10 @@ class Node(NailgunObject):
> >
> > @classmethod
> > def make_slave_name(cls, instance):
> > - return u"node-{node_id}".format(node_id=instance.id)
> > + if instance.name.startswith("Untitled"):
> > + return u"node-{node_id}".format(node_id=instance.id)
> > + else:
> > + return u"{node_id}".format(node_id=instance.name.lower())
> >
> > @classmethod
> > def make_slave_fqdn(cls, instance):
> >
> > Should I consider this as a bug or this blueprint will be implemented in
> the
> > nearest future?
> >
> >
> > --
> > Kind regards
> > Dmitry Ukov
> > IT Engineer
> > Mirantis, Inc.
> >
> >
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev@lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
--
Mike Scherbakov
#mihgen
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
