Approved. Michael
On Thu, Sep 4, 2014 at 9:36 AM, Joe Gordon <joe.gord...@gmail.com> wrote: > > > > On Wed, Sep 3, 2014 at 11:30 PM, Michael Still <mi...@stillhq.com> wrote: >> >> I'm good with this one too, so that makes three if Joe is ok with this. > > > I am ok with this, I hope the move to oslo.db will fix a few bugs for us and > the nova patch to review isn't too bad. > >> >> >> @Josh -- can you please take a look at the TH failures? >> >> Thanks, >> Michael >> >> On Wed, Sep 3, 2014 at 8:10 PM, Matt Riedemann >> <mrie...@linux.vnet.ibm.com> wrote: >> > >> > >> > On 9/3/2014 5:08 PM, Andrey Kurilin wrote: >> >> >> >> Hi All! >> >> >> >> I'd like to ask for a feature freeze exception for porting nova to use >> >> oslo.db. >> >> >> >> This change not only removes 3k LOC, but fixes 4 bugs(see commit >> >> message >> >> for more details) and provides relevant, stable common db code. >> >> >> >> Main maintainers of oslo.db(Roman Podoliaka and Victor Sergeyev) are OK >> >> with this. >> >> >> >> Joe Gordon and Matt Riedemann are already signing up, so we need one >> >> more vote from Core developer. >> >> >> >> By the way a lot of core projects are using already oslo.db for a >> >> while: keystone, cinder, glance, ceilometer, ironic, heat, neutron and >> >> sahara. So migration to oslo.db won’t produce any unexpected issues. >> >> >> >> Patch is here: https://review.openstack.org/#/c/101901/ >> >> >> >> -- >> >> Best regards, >> >> Andrey Kurilin. >> >> >> >> >> >> _______________________________________________ >> >> OpenStack-dev mailing list >> >> OpenStack-dev@lists.openstack.org >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> > >> > Just re-iterating my agreement to sponsor this. I'm waiting for the >> > latest >> > patch set to pass Jenkins and for Roman to review after his comments >> > from >> > the previous patch set and -1. Otherwise I think this is nearly ready >> > to >> > go. >> > >> > The turbo-hipster failures on the change appear to be infra issues in >> > t-h >> > rather than problems with the code. >> > >> > -- >> > >> > Thanks, >> > >> > Matt Riedemann >> > >> > >> > _______________________________________________ >> > OpenStack-dev mailing list >> > OpenStack-dev@lists.openstack.org >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> -- >> Rackspace Australia >> >> _______________________________________________ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Rackspace Australia _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev