What is going on with this? If I do a fresh clone of heat and run `tox -epep8` then I get that complaint. If I then run the recommended command to fix it, and then `tox -epep8` again, I get the same complaint again --- and with different differences exhibited! The email below carries a typescript showing this.
What I really need to know is what to do when committing a change that really does require a change in the sample configuration file. Of course I tried running generate_sample.sh, but `tox -epep8` still complains. What is the right procedure to get a correct sample committed? BTW, I am doing the following admittedly risky thing: I run DevStack, and make my changes in /opt/stack/heat/. Thanks, Mike ----- Forwarded by Mike Spreitzer/Watson/IBM on 08/24/2014 03:03 AM ----- From: ubuntu@mjs-dstk-821a (Ubuntu) To: Mike Spreitzer/Watson/IBM@IBMUS, Date: 08/24/2014 02:55 AM Subject: fresh flake fail ubuntu@mjs-dstk-821a:~/code$ git clone git://git.openstack.org/openstack/heat.git Cloning into 'heat'... remote: Counting objects: 49690, done. remote: Compressing objects: 100% (19765/19765), done. remote: Total 49690 (delta 36660), reused 39014 (delta 26526) Receiving objects: 100% (49690/49690), 7.92 MiB | 7.29 MiB/s, done. Resolving deltas: 100% (36660/36660), done. Checking connectivity... done. ubuntu@mjs-dstk-821a:~/code$ cd heat ubuntu@mjs-dstk-821a:~/code/heat$ tox -epep8 pep8 create: /home/ubuntu/code/heat/.tox/pep8 pep8 installdeps: -r/home/ubuntu/code/heat/requirements.txt, -r/home/ubuntu/code/heat/test-requirements.txt pep8 develop-inst: /home/ubuntu/code/heat pep8 runtests: PYTHONHASHSEED='0' pep8 runtests: commands[0] | flake8 heat bin/heat-api bin/heat-api-cfn bin/heat-api-cloudwatch bin/heat-engine bin/heat-manage contrib pep8 runtests: commands[1] | /home/ubuntu/code/heat/tools/config/check_uptodate.sh --- /tmp/heat.ep2CBe/heat.conf.sample2014-08-24 06:52:54.164849999 +0000 +++ etc/heat/heat.conf.sample2014-08-24 06:48:13.664849999 +0000 @@ -164,7 +164,7 @@ #allowed_rpc_exception_modules=oslo.messaging.exceptions,nova.exception,cinder.exception,exceptions # Qpid broker hostname. (string value) -#qpid_hostname=heat +#qpid_hostname=localhost # Qpid broker port. (integer value) #qpid_port=5672 @@ -221,7 +221,7 @@ # The RabbitMQ broker address where a single node is used. # (string value) -#rabbit_host=heat +#rabbit_host=localhost # The RabbitMQ broker port where a single node is used. # (integer value) check_uptodate.sh: heat.conf.sample is not up to date. check_uptodate.sh: Please run /home/ubuntu/code/heat/tools/config/generate_sample.sh. ERROR: InvocationError: '/home/ubuntu/code/heat/tools/config/check_uptodate.sh' pep8 runtests: commands[2] | /home/ubuntu/code/heat/tools/requirements_style_check.sh requirements.txt test-requirements.txt pep8 runtests: commands[3] | bash -c find heat -type f -regex '.*\.pot?' -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null ___________________________________ summary ____________________________________ ERROR: pep8: commands failed ubuntu@mjs-dstk-821a:~/code/heat$ ubuntu@mjs-dstk-821a:~/code/heat$ ubuntu@mjs-dstk-821a:~/code/heat$ tools/config/generate_sample.sh ubuntu@mjs-dstk-821a:~/code/heat$ ubuntu@mjs-dstk-821a:~/code/heat$ ubuntu@mjs-dstk-821a:~/code/heat$ ubuntu@mjs-dstk-821a:~/code/heat$ tox -epep8 pep8 develop-inst-noop: /home/ubuntu/code/heat pep8 runtests: PYTHONHASHSEED='0' pep8 runtests: commands[0] | flake8 heat bin/heat-api bin/heat-api-cfn bin/heat-api-cloudwatch bin/heat-engine bin/heat-manage contrib pep8 runtests: commands[1] | /home/ubuntu/code/heat/tools/config/check_uptodate.sh --- /tmp/heat.DqIhK5/heat.conf.sample2014-08-24 06:54:34.628849999 +0000 +++ etc/heat/heat.conf.sample2014-08-24 06:53:51.540849999 +0000 @@ -159,10 +159,6 @@ # Size of RPC connection pool. (integer value) #rpc_conn_pool_size=30 -# Modules of exceptions that are permitted to be recreated -# upon receiving exception data from an rpc call. (list value) -#allowed_rpc_exception_modules=oslo.messaging.exceptions,nova.exception,cinder.exception,exceptions - # Qpid broker hostname. (string value) #qpid_hostname=heat @@ -301,15 +297,6 @@ # Heartbeat time-to-live. (integer value) #matchmaker_heartbeat_ttl=600 -# Host to locate redis. (string value) -#host=127.0.0.1 - -# Use this port to connect to redis host. (integer value) -#port=6379 - -# Password for Redis server (optional). (string value) -#password=<None> - # Size of RPC greenthread pool. (integer value) #rpc_thread_pool_size=64 @@ -1229,6 +1216,22 @@ #hash_algorithms=md5 +[matchmaker_redis] + +# +# Options defined in oslo.messaging +# + +# Host to locate redis. (string value) +#host=127.0.0.1 + +# Use this port to connect to redis host. (integer value) +#port=6379 + +# Password for Redis server (optional). (string value) +#password=<None> + + [matchmaker_ring] # check_uptodate.sh: heat.conf.sample is not up to date. check_uptodate.sh: Please run /home/ubuntu/code/heat/tools/config/generate_sample.sh. ERROR: InvocationError: '/home/ubuntu/code/heat/tools/config/check_uptodate.sh' pep8 runtests: commands[2] | /home/ubuntu/code/heat/tools/requirements_style_check.sh requirements.txt test-requirements.txt pep8 runtests: commands[3] | bash -c find heat -type f -regex '.*\.pot?' -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null ___________________________________ summary ____________________________________ ERROR: pep8: commands failed ubuntu@mjs-dstk-821a:~/code/heat$
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
