On Fri, Aug 15, 2014 at 7:28 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, Aug 15, 2014 at 06:53:41AM +1000, Michael Still wrote: >> On Fri, Aug 15, 2014 at 6:37 AM, Dan Smith <d...@danplanet.com> wrote: >> >> == Move Virt Drivers to use Objects (Juno Work) == >> >> >> >> I couldn't actually find any code out for review for this one apart >> >> from https://review.openstack.org/#/c/94477/, is there more out there? >> > >> > This was an umbrella one to cover a bunch of virt driver objects work >> > done early in the cycle. Much of that is done, I haven't gone looking >> > for anything to see if there are any obvious things to include under >> > this anymore, but I'll try to do that. >> >> Thanks, I'd appreciate that. If its all done, we should mark it implemented. >> >> >> == Add a virt driver for Ironic == >> >> >> >> This one is in progress, but we need to keep going at it or we wont >> >> get it merged in time. >> >> >> >> * https://review.openstack.org/#/c/111223/ was approved, but a rebased >> >> ate it. Should be quick to re-approve. >> >> * https://review.openstack.org/#/c/111423/ >> >> * https://review.openstack.org/#/c/111425/ >> >> * ...there are more reviews in this series, but I'd be super happy to >> >> see even a few reviewed >> > >> > I've been reviewing this pretty heavy and I think that it's just taking >> > a while to make changes given the roundabout way they're getting done >> > first in Ironic. I'm pretty confident that this one will be okay. >> >> Yep, I appreciate your focus on this one -- as I am sure the ironic >> people do too. If another core was available to pair up with you on >> these we might be able to get them to land faster. I was doing that >> for a while, but I haven't had time in the last week or so. > > I've reviewed some parts of Ironic, but I see we've not broken it > up into a number of parts, which I personally think is counter > productive because we'll have more pain in waiting in the gate, > but oh well. I'll continue looking at it.
I'm not sure I follow. The driver is broken up into a series of reviews in a series. The ones yet to merge are: https://review.openstack.org/#/c/111223/ https://review.openstack.org/#/c/111423/ https://review.openstack.org/#/c/111425/ https://review.openstack.org/#/c/111428/ https://review.openstack.org/#/c/111429/ Michael -- Rackspace Australia _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
