On 06-Aug-14 20:20, Zane Bitter wrote: > On 06/08/14 10:37, Anant Patil wrote: >> Hi, >> >> I see that the stack delete method is too long to comprehend easily >> without going to-and-fro few times. I think we should refactor it and >> move out the "UpdateReplace" related logic for backup stack to another >> method. We can also move the user credentials deletion related logic to >> another method. With this we will can have more testable (each method >> can be tested independently) and lucid code. >> >> Don't know if someone has already taken it. I am sure the refactor will >> be helpful. > > When the current update-failure-recovery stuff I am working on is done > we're going to have the same bug with updates that this code is solving > for deletes. So I was expecting to do some refactoring along these lines > anyway. > > BTW, I suggest you put [Heat] in the subject line when posting to > openstack-dev if you want Heat developers to see it. > > cheers, > Zane. > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
Sure. I think its critical we do that. > BTW, I suggest you put [Heat] in the subject line when posting to > openstack-dev if you want Heat developers to see it. I had re-sent with appropriate subject realizing it later. _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
