On 22 June 2014 14:41, Amrith Kumar <amr...@tesora.com> wrote: > In addition to making changes to the hacking rules, why don't we mandate also > that perceived problems in the commit message shall not be an acceptable > reason to -1 a change.
-1. There are some /really/ bad commit messages out there, and some of us try to use the commit messages to usefully sort through the changes (i.e. I often -1 in cinder a change only affects one driver and that isn't clear from the summary). If the perceived problem is grammatical, I'm a bit more on board with it not a reason to rev a patch, but core reviewers can +2/A over the top of a -1 anyway... > Would this improve the situation? Writing better commit messages in the first place would improve the situation? _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
