This is a fix in flight for the vmware driver. It also throws an exception on disk size reduction.
https://review.openstack.org/#/c/85804/ On Jun 13, 2014, at 3:02 AM, "Day, Phil" <philip....@hp.com> wrote: > Hi Folks, > > I was looking at the resize code in libvirt, and it has checks which raise an > exception if the target root or ephemeral disks are smaller than the current > ones – which seems fair enough I guess (you can’t drop arbitary disk content > on resize), except that the because the check is in the virt driver the > effect is to just ignore the request (the instance remains active rather than > going to resize-verify). > > It made me wonder if there were any hypervisors that actually allow this, and > if not wouldn’t it be better to move the check to the API layer so that the > request can be failed rather than silently ignored ? > > As far as I can see: > > baremetal: Doesn’t support resize > > hyperv: Checks only for root disk > (https://github.com/openstack/nova/blob/master/nova/virt/hyperv/migrationops.py#L99-L108 > ) > > libvirt: fails for a reduction of either root or ephemeral > (https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4918-L4923 > ) > > vmware: doesn’t seem to check at all ? > > xen: Allows resize down for root but not for ephemeral > (https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L1015-L1032 > ) > > > It feels kind of clumsy to have such a wide variation of behavior across the > drivers, and to have the check performed only in the driver ? > > Phil > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
