Team, what do you think about doing this for Marconi? It looks like we indeed have a sample checked in:
https://review.openstack.org/#/c/83006/1/etc/marconi.conf.sample Personally, I think we should keep the sample until generate_sample.sh works on OS X (we could even volunteer to fix it); otherwise, people with MBPs will be in a bit of a bind. --- Kurt G. | @kgriffs On 3/26/14, 1:15 PM, "Russell Bryant" <rbry...@redhat.com> wrote: >On 03/26/2014 02:10 PM, Clint Byrum wrote: >> This is an issue that affects all of our git repos. If you are using >> oslo.config, you will likely also be using the sample config generator. >> >> However, for some reason we are all checking this generated file in. >> This makes no sense, as we humans are not editting it, and it often >> picks up config files from other things like libraries (keystoneclient >> in particular). This has lead to breakage in the gate a few times for >> Heat, perhaps for others as well. >> >> I move that we all rm this file from our git trees, and start generating >> it as part of the install/dist process (I have no idea how to do >> this..). This would require: >> >> - rm sample files and add them to .gitignore in all trees >> - Removing check_uptodate.sh from all trees/tox.ini's >> - Generating file during dist/install process. >> >> Does anyone disagree? > >This has been done in Nova, except we don't have it generated during >install. We just have instructions and a tox target that will do it if >you choose to. > >https://git.openstack.org/cgit/openstack/nova/tree/etc/nova/README-nova.co >nf.txt > >Related, adding instructions to generate without tox: >https://review.openstack.org/#/c/82533/ > >-- >Russell Bryant > >_______________________________________________ >OpenStack-dev mailing list >OpenStack-dev@lists.openstack.org >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
