On Tue, Oct 9, 2018 at 12:30 PM Doug Hellmann <d...@doughellmann.com> wrote:
> Ken Giusti <kgiu...@gmail.com> writes: > > > On Tue, Oct 9, 2018 at 11:56 AM Doug Hellmann <d...@doughellmann.com> > wrote: > > > >> Matthew Thode <prometheanf...@gentoo.org> writes: > >> > >> > On 18-10-09 11:12:30, Doug Hellmann wrote: > >> >> Matthew Thode <prometheanf...@gentoo.org> writes: > >> >> > >> >> > several projects have had problems with the new release, some have > >> ways > >> >> > of working around it, and some do not. I'm sending this just to > raise > >> >> > the issue and allow a place to discuss solutions. > >> >> > > >> >> > Currently there is a review proposed to blacklist 9.0.0, but if > this > >> is > >> >> > going to still be an issue somehow in further releases we may need > >> >> > another solution. > >> >> > > >> >> > https://review.openstack.org/#/c/608835/ > >> >> > > >> >> > -- > >> >> > Matthew Thode (prometheanfire) > >> >> > > >> > __________________________________________________________________________ > >> >> > OpenStack Development Mailing List (not for usage questions) > >> >> > Unsubscribe: > >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > >> >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >> >> > >> >> Do you have links to the failure logs or bug reports or something? > If I > >> >> wanted to help I wouldn't even know where to start. > >> >> > >> > > >> > > >> > http://logs.openstack.org/21/607521/2/check/cross-cinder-py35/e15722e/testr_results.html.gz > >> > >> These failures look like we should add a proper API to oslo.messaging to > >> set the notification and rpc backends for testing. The configuration > >> options are *not* part of the API of the library. > >> > >> There is already an oslo_messaging.conffixture module with a fixture > >> class, but it looks like it defaults to rabbit. Maybe someone wants to > >> propose a patch to make that a parameter to the constructor? > >> > > > > oslo.messaging's conffixture uses whatever the config default for > > transport_url is unless the test > > specifically overrides it by setting the transport_url attribute. > > The o.m. unit tests's base test class sets conffixture.transport_url to > > "fake:/" to use the fake in memory driver. > > That's the existing practice (I believe it's used like that outside of > o.m.) > > OK, so it sounds like the fixture is relying on the configuration to be > set up in advance, and that's the thing we need to change. We don't want > users outside of the library to set up tests by using the configuration > options, right? > That's the intent of ConfFixture it seems - provide a wrapper API so tests don't have to monkey directly with the config. How about this: https://review.openstack.org/609063 > > Doug > -- Ken Giusti (kgiu...@gmail.com)
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
