> On Mar 8, 2018, at 22:52, Rong Zhu <aaronzhu1...@gmail.com> wrote: > > Hi, Tony > > I will fix this in stable pike, thanks for the reminder. > >
Just to make sure the point wasn’t missed - this needs to be fixed in master yet. The change that was made there is not correct, so rather than backporting that just to get the tests to pass, it needs to be properly fixed, and only then backported. > > > On Fri, Mar 9, 2018 at 12:32 PM, Tony Breeds <t...@bakeyournoodle.com> wrote: >> On Thu, Mar 08, 2018 at 06:16:27AM +0000, A mailing list for the OpenStack >> Stable Branch test reports. wrote: >>> Build failed. >>> >>> - build-openstack-sphinx-docs >>> http://logs.openstack.org/periodic-stable/git.openstack.org/openstack/murano/stable/pike/build-openstack-sphinx-docs/8b023b7/html/ >>> : SUCCESS in 4m 44s >>> - openstack-tox-py27 >>> http://logs.openstack.org/periodic-stable/git.openstack.org/openstack/murano/stable/pike/openstack-tox-py27/82d0dae/ >>> : FAILURE in 5m 48s >> >> The job is failing on the periodic-stable pipeline which indicates that >> all changes on pike will hit this same issue. >> >> There is fix on master[1] but it's wrong so rather than back porting >> that pike it'd be great if someone from the murano team could own fixing >> this properly. >> >> Based on my 5mins of poking it seems that reading the test yaml file is >> generating a list of unicode values rather than the expected list of >> string_type(). I think the answer is a simple as iterating over the >> list and using six.string_type to massage the value. I don't knwo what >> else that will break and I also don't know the details of the contract >> that allowed pattern is describing. >> >> For example making it a simple string value would probably also fix it >> but that isn't a backwards compatible change. >> >> Yours Tony. >> >> [1] >> https://review.openstack.org/#/c/523829/4/murano/tests/unit/packages/hot_package/test_hot_package.py@114 >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > > -- > Thanks, > Rong Zhu > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
