Thanks for clarification. I was a bit confused with the two things because the patch dropped some embedded stuffs like font-awesome. Let's address the "embedded" problem soon :)
Akihiro 2018-03-02 14:27 GMT+00:00 Xinni Ge <xinni.ge1...@gmail.com>: > Hi, Akihiro, > > The patch I submitted previously didn't solve the embedded problem. > I would like to fix out the whole thing in several steps, because the > current status of static files arrangment is quite messy. > > I will upload the javascript and css style files as xstatic-* projects and > remove them from the code later on. > > I wanted to solve the unittest problem ASAP and assumed it will take some > time to create xstatic repos and get the approval from infra team, > so I just submitted this patch to let unittest go well at first. > > Thanks for asking, I am happy to hear from your all about the js and static > files issue. > > Best regards, > > Xinni > > On Fri, Mar 2, 2018 at 1:29 PM, Akihiro Motoki <amot...@gmail.com> wrote: >> >> Hi Xinni, >> >> I looked at your patch which drops the vendors stuffs, but I still >> have a question. >> >> The patch introduces some SCSS like: >> - bootstrap.scss >> - angular-notify.scss >> - angular-material.scss >> >> Aren't they another type of "vendors" stuffs? >> I don't understand why switching to SCSS solves the embedded "vendors" >> problem? >> >> I would like to know opinions from zigo and Corey. >> >> Thanks, >> Akihiro >> >> >> 2018-03-01 21:30 GMT+00:00 Xinni Ge <xinni.ge1...@gmail.com>: >> > Hi, there. >> > >> > This is a page of a similar unittest issue. >> > https://bugs.launchpad.net/heat-dashboard/+bug/1752527 >> > >> > We merged the following patch to fix the issue, and hope it also fix the >> > trouble described here. >> > https://review.openstack.org/#/c/548924/ >> > >> > As for the minified javascript files, we are working on removing from >> > the >> > source code, >> > and uploading as xstatic packages. >> > Just need a little more time to finish it. >> > >> > >> > Best regards, >> > >> > Xinni >> > >> > On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand <z...@debian.org> >> > wrote: >> >> >> >> On 02/23/2018 09:29 AM, Xinni Ge wrote: >> >> > Hi there, >> >> > >> >> > We are aware of the javascript embedded issue, and working on it now, >> >> > the patch will be summited later. >> >> > >> >> > As for the unittest failure, we are still investigating it. We will >> >> > contant you as soon as we find out the cause. >> >> > >> >> > Sorry to bring troubles to you. We will be grateful if you could wait >> >> > for a little longer. >> >> > >> >> > Best Regards, >> >> > >> >> > Xinni >> >> >> >> Hi, >> >> >> >> Thanks for this message. This lowers the frustration! :) >> >> Let me know if there's any patch I could review. >> >> >> >> Cheers, >> >> >> >> Thomas Goirand (zigo) >> >> >> >> >> >> __________________________________________________________________________ >> >> OpenStack Development Mailing List (not for usage questions) >> >> Unsubscribe: >> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > >> > >> > >> > >> > -- >> > 葛馨霓 Xinni Ge >> > >> > >> > __________________________________________________________________________ >> > OpenStack Development Mailing List (not for usage questions) >> > Unsubscribe: >> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > -- > 葛馨霓 Xinni Ge > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
