Hi all, Matt wrote: > Wouldn't it be a good idea to check for more general DBError? > > So like catching Exception? How are you going to distinguish from > IntegrityErrors which shouldn't be retried, which are also DBErrors? >
Are IntegrityErrors really possible when testing new engine's connection? Usually, test queries are simple, like SELECT 1; 2018-02-28 9:55 GMT+04:00 Vitalii Solodilov <[email protected]>: > Hi folks! > > I have a question about oslo_db "max_retries" option. > https://github.com/openstack/oslo.db/blob/master/oslo_db/ > sqlalchemy/engines.py#L381 > Why only DBConnectionError is considered as a reason for reconnecting here? > Wouldn't it be a good idea to check for more general DBError? > For example, DB host is down at the time of engine creation, but will > become running some time later. > > -- > Best regards, > > Vitalii Solodilov > > -- Best regards, Anton Kazakov
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
