On 18-01-17 21:24:12, John Villalovos wrote: > I have updated the bug with info I found out: > https://bugs.launchpad.net/oslo.serialization/+bug/1728368 > > Also I did a test patch with a proposed change: > https://review.openstack.org/#/c/535166/ > > This patch causes the unit tests to work. > > As a note there is a deprecation warning in the current code (without my > patch) that says in the future it will raise a ValueError() as can be seen > in a recently merged patch: > http://logs.openstack.org/72/533872/6/check/openstack-tox-py27/4709e32/job-output.txt.gz#_2018-01-16_13_10_38_931593 > > The test patch gets rid of that deprecation warning for the exceptions. > > Though I did see another warning about the "Response" object: > http://logs.openstack.org/66/535166/2/check/openstack-tox-py35/33d0827/job-output.txt.gz#_2018-01-18_05_13_52_603162 > > But that is for someone else to figure out :) > > > > On Wed, Jan 17, 2018 at 7:13 PM, ChangBo Guo <glongw...@gmail.com> wrote: > > > add Ironic team in the loop > > > > the revert patch got -1 from ironic folks , more details please see the > > comments in https://review.openstack.org/534736 > > The possible solution is to figure out why the change break Glance's unit > > test. which side should be fixed. > > > > > > > > 2018-01-17 20:14 GMT+08:00 ChangBo Guo <glongw...@gmail.com>: > > > >> I dig a little. It shows success when updating constraint to 2.21.2 [1] > >> but failure when updating constraint to 2.22.0 [2]. according to release > >> information [3]. > >> It means 2.21.1 works with glance test but 2.21.2 doesn't work well with > >> glance. The only issue patch is https://github.com/openstack/o > >> slo.serialization/commit/c1a7079c26d27a2e46cca26963d3d9aa040bdbe8. > >> > >> > >> [1] https://review.openstack.org/514833 > >> [2] https://review.openstack.org/#/c/525136 > >> [3] https://github.com/openstack/releases/blob/master/deliverabl > >> es/queens/oslo.serialization.yaml > >> > >> > >> Actions: > >> > >> Block oslo.serialization version 2.21.2, 2.22.0, 2. 23.0 in > >> https://review.openstack.org/534739 > >> Revert c1a7079c26d27a2e46cca26963d3d9aa040bdbe8 in > >> https://review.openstack.org/534736 > >> > >> > >> > >> > >> 2018-01-16 23:35 GMT+08:00 Matthew Thode <prometheanf...@gentoo.org>: > >> > >>> On 18-01-16 19:12:16, ChangBo Guo wrote: > >>> > What's the issue for Glance, any bug link ? > >>> > > >>> > 2018-01-16 0:12 GMT+08:00 Matthew Thode <prometheanf...@gentoo.org>: > >>> > > >>> > > On 18-01-13 00:41:28, Matthew Thode wrote: > >>> > > > https://review.openstack.org/531788 is the review we are seeing > >>> it in, > >>> > > > but 2.22.0 failed as well. > >>> > > > > >>> > > > I'm guessing it was introduced in either > >>> > > > > >>> > > > https://github.com/openstack/oslo.serialization/commit/ > >>> > > c1a7079c26d27a2e46cca26963d3d9aa040bdbe8 > >>> > > > or > >>> > > > https://github.com/openstack/oslo.serialization/commit/ > >>> > > cdb2f60d26e3b65b6370f87b2e9864045651c117 > >>> > > > >>> > > bamp > >>> > > > >>> > >>> The best bug for this is > >>> https://bugs.launchpad.net/oslo.serialization/+bug/1728368 and we are > >>> currently getting test fails in https://review.openstack.org/531788 > >>>
Thanks for that, will keep an eye on it. -- Matthew Thode (prometheanfire)
signature.asc
Description: PGP signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
