On Tue, Dec 12, 2017 at 4:56 AM, Moshe Levi <mosh...@mellanox.com> wrote: > I believe so, > Just regarding the use of sample-env-generator tool is not supporting > parameters for roles: > Such as : > > # Kernel arguments for ComputeSriov node > ComputeSriovParameters: > KernelArgs: "intel_iommu=on iommu=pt" > OvsHwOffload: True >
It can, you just have to document them in the env generator file. See https://github.com/openstack/tripleo-heat-templates/blob/master/sample-env-generator/composable-roles.yaml#L128 This has the advantage of being able to properly document the parameters for end user consumption. > So can we merged the patches as is and fix the sample-env-generator late? If you throw up a WIP patch for this on top of the existing one, I'll merge it. I just don't want it forgotten as it's important for the end user to be able to consume these environment files via the UI as well. Thanks, -Alex > >> -----Original Message----- >> From: Alex Schultz [mailto:aschu...@redhat.com] >> Sent: Tuesday, December 12, 2017 12:20 AM >> To: OpenStack Development Mailing List (not for usage questions) >> <openstack-dev@lists.openstack.org> >> Subject: Re: [openstack-dev] [tripleo] Blueprints moved out to Rocky >> >> On Mon, Dec 11, 2017 at 1:20 PM, Brad P. Crochet <b...@redhat.com> >> wrote: >> > >> > >> > On Fri, Dec 8, 2017 at 6:35 PM Alex Schultz <aschu...@redhat.com> wrote: >> >> >> >> Hey folks, >> >> >> >> So I went through the list of blueprints and moved some that were >> >> either not updated or appeared to have a bunch of patches not in a >> >> mergable state. >> >> >> >> Please take some time to review the list of blueprints currently >> >> associated with Rocky[0] to see if your efforts have been moved. If >> >> you believe you're close to implementing the feature in the next week >> >> or two, let me know and we can move it back into Queens. If you think >> >> it will take an extended period of time (more than 2 weeks) to land >> >> but we need it in Queens, please submit an FFE. >> >> >> > >> > I think these are in a close enough state to warrant inclusion in Queens: >> > >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Fget-networks- >> action&data=0 >> > >> 2%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8ccc08d540e56 >> 51a%7Ca >> > >> 652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636486276360618857&sda >> ta=EKi >> > 0yRd07V01KvoZoiQY%2FMIZU9OPZHez6%2F06PL7e7EU%3D&reserved=0 >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Ftripleo-common-list- >> availa >> > ble-roles- >> action&data=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee862294 >> > >> 7ea8ccc08d540e5651a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7 >> C63648 >> > >> 6276360618857&sdata=rNn1Ujf2XKCslsW7idN1qJwn0DWpN7I8A4gvYWiELbI >> %3D&res >> > erved=0 >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Ftripleo-common-select- >> role >> > s- >> workflow&data=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947 >> ea8cc >> > >> c08d540e5651a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6364 >> 8627636 >> > >> 0618857&sdata=jpH6L7d1c0w6WDZxPoeDeHBzb0T2FIgEhHiT3PElEMg%3D&re >> served= >> > 0 >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Fupdate-networks- >> action&dat >> > >> a=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8ccc08d540 >> e5651a% >> > >> 7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636486276360618857& >> sdata= >> > AlBpvtX3kdMedrO%2BehaRaTUhl%2BUclJdesiqsu7HvvEA%3D&reserved=0 >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Fvalidate-roles- >> networks&da >> > >> ta=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8ccc08d540 >> e5651a >> > >> %7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63648627636061885 >> 7&sdata >> > >> =uDK%2F4Wo9S0D9qySb%2BORYVE1HDtrJ0J6Ec8qWU8hUwkw%3D&reserve >> d=0 >> > >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fblu >> > eprints.launchpad.net%2Ftripleo%2F%2Bspec%2Fupdate-roles- >> action&data=0 >> > >> 2%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8ccc08d540e56 >> 51a%7Ca >> > >> 652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636486276360618857&sda >> ta=Oos >> > SA5xeI4L4Ue6XbPh1Wd83tUU1SehQG%2BaSxRFXNW8%3D&reserved=0 >> > >> >> Ok I reviewed them and they do appear to have patches posted and are >> getting reviews. I'll pull them back in to Queens and set the milestone to >> queens-3. Please make sure to update us on the status during this week and >> next week's IRC meetings. I would like to make sure these land ASAP. Do you >> think they should be in a state to land by the end of next week say 12/21? >> >> Thanks, >> -Alex >> >> > There is a good chance of these being completed in the coming week. >> > >> > Thanks, >> > >> > Brad >> >> >> >> >> > -- >> > Brad P. Crochet, RHCA, RHCE, RHCVA, RHCDS Principal Software Engineer >> > (c) 704.236.9385 >> > >> > >> > >> __________________________________________________________ >> ________________ >> > OpenStack Development Mailing List (not for usage questions) >> > Unsubscribe: OpenStack-dev- >> requ...@lists.openstack.org?subject:unsubscribe >> > >> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists. >> openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack- >> dev&data=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8cc >> c08d540e5651a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6364 >> 86276360618857&sdata=vzMYyfhGhBEbJjEWeBCjQwAdsOdk7ZokGM7RI63Re >> NQ%3D&reserved=0 >> > >> >> __________________________________________________________ >> ________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: OpenStack-dev- >> requ...@lists.openstack.org?subject:unsubscribe >> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists. >> openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack- >> dev&data=02%7C01%7Cmoshele%40mellanox.com%7Caf36fee8622947ea8cc >> c08d540e5651a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6364 >> 86276360618857&sdata=vzMYyfhGhBEbJjEWeBCjQwAdsOdk7ZokGM7RI63Re >> NQ%3D&reserved=0 > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
