Hi Yoshihiro, In my opinion the use of filters on changes is allowed by the smoketesting policy we defined. Notwithstanding that the approach of testing every patch is definitely the safest, I understand in some cases the volume of patchsets uploaded to gerrit might overwhelm the plugin-specific testing system, especially in cases where not much resources are dedicated to it.
I would suggest to test every patch which has changes in the following packages: neutron.db neutron.api neutron.extensions neutron.plugin.<your-plugin> neutron.openstack neutron.agent (if your plugin uses any of the agents) Regards, Salvatore On 10 December 2013 06:09, Yoshihiro Kaneko <ykaneko0...@gmail.com> wrote: > 2013/12/10 Matt Riedemann <mrie...@linux.vnet.ibm.com>: > > > > > > On Sunday, December 08, 2013 11:32:50 PM, Yoshihiro Kaneko wrote: > >> > >> Hi Neutron team, > >> > >> I'm working on building Third-party testing for Neutron Ryu plugin. > >> I intend to use Jenkins and gerrit-trigger plugin. > >> > >> It is required that Third-party testing provides verify vote for > >> all changes to a plugin/driver's code, and all code submissions > >> by the jenkins user. > >> > >> > https://wiki.openstack.org/wiki/Neutron_Plugins_and_Drivers#Testing_Requirements > >> > >> For this requirements, what kind of filter for the trigger should > >> I set? > >> It is easy to set a file path of the plugin/driver: > >> project: plain:neutron > >> branch: plain:master > >> file: path:neutron/plugins/ryu/** > >> However, this is not enough because it lacks dependencies. > >> It is difficult to judge a patchset which affects the plugin/driver. > >> In addition, gerrit trigger has a file path filter, but there is no > >> patchset owner filter, so it is not able to set a trigger to a > >> patchset which is submitted by the jenkins user. > >> > >> Can Third-party testing execute tests for all patchset including the > >> thing which may not affect the plugin/driver? > >> > >> Thanks, > >> Kaneko > >> > >> _______________________________________________ > >> OpenStack-dev mailing list > >> OpenStack-dev@lists.openstack.org > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >> > > > > I can't speak for the Neutron team, but in Nova the requirement is to run > > all patches through the vendor plugin third party CI, not just > > vendor-specific patches. > > Thanks for the reply, Matt. > I believe that it is the right way for a smoke testing. > > > > > https://wiki.openstack.org/wiki/HypervisorSupportMatrix/DeprecationPlan > > > > -- > > > > Thanks, > > > > Matt Riedemann > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
