On Fri, 2017-06-09 at 09:24 -0600, Alex Schultz wrote: > Hey folks, > > I wanted to bring to your attention that we've merged the change[0] > to > add a basic set of roles that can be combined to create your own > roles_data.yaml as needed. With this change the roles_data.yaml and > roles_data_undercloud.yaml files in THT should not be changed by > hand.
In general I like the feature. I added some comments to your validations [1] patch below. We need those validations, but I think we need to carefully consider adding a hard dependency on python-tripleoclient simply to have validations in tree. Wondering if perhaps a t-h-t-utils library project might be in order here to contain routines we use in t-h-t and in higher level workflow tools in Mistral and on the CLI? This might also make the tools/process-templates.py stuff cleaner as well. Thoughts? Dan > Instead if you have an update to a role, please update the > appropriate > roles/*.yaml file. I have proposed a change[1] to THT with additional > tools to validate that the roles/*.yaml files are updated and that > there are no unaccounted for roles_data.yaml changes. Additionally > this change adds in a new tox target to assist in the generate of > these basic roles data files that we provide. > > Ideally I would like to get rid of the roles_data.yaml and > roles_data_undercloud.yaml so that the end user doesn't have to > generate this file at all but that won't happen this cycle. In the > mean time, additional documentation around how to work with roles has > been added to the roles README[2]. > > Thanks, > -Alex > > [0] https://review.openstack.org/#/c/445687/ > [1] https://review.openstack.org/#/c/472731/ > [2] https://github.com/openstack/tripleo-heat-templates/blob/master/r > oles/README.rst > > _____________________________________________________________________ > _____ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubs > cribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
