Hi Team, pep8 is failing in master code. *translation hint helpers *are removed from LOG messages. Is this purposefully done ? Let me know if it is not, will change it.
./networking_sfc/db/flowclassifier_db.py:342:13: N531 Log messages require translation hints! LOG.info("Deleting a non-existing flow classifier.") ^ ./networking_sfc/db/sfc_db.py:383:13: N531 Log messages require translation hints! LOG.info("Deleting a non-existing port chain.") ^ ./networking_sfc/db/sfc_db.py:526:13: N531 Log messages require translation hints! LOG.info("Deleting a non-existing port pair.") ^ ./networking_sfc/db/sfc_db.py:658:13: N531 Log messages require translation hints! LOG.info("Deleting a non-existing port pair group.") ^ ./networking_sfc/services/flowclassifier/driver_manager.py:38:9: N531 Log messages require translation hints! LOG.info("Configured Flow Classifier drivers: %s", names) ^ ./networking_sfc/services/flowclassifier/driver_manager.py:44:9: N531 Log messages require translation hints! LOG.info("Loaded Flow Classifier drivers: %s", ^ ./networking_sfc/services/flowclassifier/driver_manager.py:80:9: N531 Log messages require translation hints! LOG.info("Registered Flow Classifier drivers: %s", ^ ./networking_sfc/services/flowclassifier/driver_manager.py:87:13: N531 Log messages require translation hints! LOG.info("Initializing Flow Classifier driver '%s'", ^ ./networking_sfc/services/flowclassifier/driver_manager.py:107:17: N531 Log messages require translation hints! LOG.error( ^ ./networking_sfc/services/flowclassifier/plugin.py:63:17: N531 Log messages require translation hints! LOG.error("Create flow classifier failed, " ^ ./networking_sfc/services/flowclassifier/plugin.py:87:17: N531 Log messages require translation hints! LOG.error("Update flow classifier failed, " ^ ./networking_sfc/services/flowclassifier/plugin.py:102:17: N531 Log messages require translation hints! LOG.error("Delete flow classifier failed, " ^ ./networking_sfc/services/sfc/driver_manager.py:38:9: N531 Log messages require translation hints! LOG.info("Configured SFC drivers: %s", names) ^ ./networking_sfc/services/sfc/driver_manager.py:43:9: N531 Log messages require translation hints! LOG.info("Loaded SFC drivers: %s", self.names()) ^ ./networking_sfc/services/sfc/driver_manager.py:78:9: N531 Log messages require translation hints! LOG.info("Registered SFC drivers: %s", ^ ./networking_sfc/services/sfc/driver_manager.py:85:13: N531 Log messages require translation hints! LOG.info("Initializing SFC driver '%s'", driver.name) ^ ./networking_sfc/services/sfc/driver_manager.py:104:17: N531 Log messages require translation hints! LOG.error( ^ ./networking_sfc/services/sfc/plugin.py:57:17: N531 Log messages require translation hints! LOG.error("Create port chain failed, " ^ ./networking_sfc/services/sfc/plugin.py:82:17: N531 Log messages require translation hints! LOG.error("Update port chain failed, port_chain '%s'", ^ ./networking_sfc/services/sfc/plugin.py:97:17: N531 Log messages require translation hints! LOG.error("Delete port chain failed, portchain '%s'", ^ ./networking_sfc/services/sfc/plugin.py:122:17: N531 Log messages require translation hints! LOG.error("Create port pair failed, " ^ ./networking_sfc/services/sfc/plugin.py:144:17: N531 Log messages require translation hints! LOG.error("Update port pair failed, port_pair '%s'", ^ ./networking_sfc/services/sfc/plugin.py:159:17: N531 Log messages require translation hints! LOG.error("Delete port pair failed, port_pair '%s'", ^ ./networking_sfc/services/sfc/plugin.py:185:17: N531 Log messages require translation hints! LOG.error("Create port pair group failed, " ^ ./networking_sfc/services/sfc/plugin.py:213:17: N531 Log messages require translation hints! LOG.error("Update port pair group failed, " ^ ./networking_sfc/services/sfc/plugin.py:229:17: N531 Log messages require translation hints! LOG.error("Delete port pair group failed, " ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:111:13: N531 Log messages require translation hints! LOG.error("SFC L2 extension handle_port failed") ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:124:9: N531 Log messages require translation hints! LOG.info("a device %s is removed", port_id) ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:129:13: N531 Log messages require translation hints! LOG.error( ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:149:13: N531 Log messages require translation hints! LOG.error("update_flow_rules failed") ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:165:13: N531 Log messages require translation hints! LOG.error("delete_flow_rules failed") ^ ./networking_sfc/services/sfc/agent/extensions/sfc.py:207:13: N531 Log messages require translation hints! LOG.error("delete_port_id_flows failed") ^ ./networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py:117:13: N531 Log messages require translation hints! LOG.error("update_flow_rules failed") ^ ./networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py:167:13: N531 Log messages require translation hints! LOG.error("delete_flow_rule failed") ^ ./networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py:227:13: N531 Log messages require translation hints! LOG.error("Current portchain agent doesn't support IPv6") ^ ./networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py:229:13: N531 Log messages require translation hints! LOG.error("invalid protocol input") ^ ./networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py:239:13: N531 Log messages require translation hints! LOG.error("Current portchain agent only supports IPv4") ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:72:13: N531 Log messages require translation hints! LOG.warning("Unable to retrieve the agent ip, check the agent " ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:77:13: N531 Log messages require translation hints! LOG.warning("Port %(port)s updated by agent %(agent)s " ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:322:13: N531 Log messages require translation hints! LOG.error('No path_id available for creating port chain path') ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:346:25: N531 Log messages require translation hints! LOG.error('Cross-subnet chain not supported') ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:378:29: N531 Log messages require translation hints! LOG.error('Cross-subnet chain not supported') ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:721:13: N531 Log messages require translation hints! LOG.warning("Not found the flow classifier service plugin") ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:983:13: N531 Log messages require translation hints! LOG.warning("Currently only support vxlan network") ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:986:13: N531 Log messages require translation hints! LOG.warning("This port has not been binding") ^ ./networking_sfc/services/sfc/drivers/ovs/driver.py:1107:13: N531 Log messages require translation hints! LOG.error("get_flowrules_by_host_portid failed") ^ ./networking_sfc/services/sfc/drivers/ovs/rpc.py:44:9: N531 Log messages require translation hints! LOG.info('update_flowrules_status: %s', flowrules_status) ^ ERROR: InvocationError: '/home/vikash/python_src/networking-sfc/.tox/pep8/bin/flake8' ______________________________________________________________________ summary _______________________________________________________________________ ERROR: pep8: commands failed -- Regards, Vikash
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev