+1 on the inline method. It makes it clear when a notification should be emitted and, as you say, handles the exception handling better.
Also, if it makes sense for Horizon, consider bracketing long-running operations in .start/.end pairs. This will help with performance tuning and early error detection. More info on "well behaved notifications" in here: http://www.sandywalsh.com/2013/09/notification-usage-in-openstack-report.html Great to see! -S On 11/25/2013 11:58 AM, Florent Flament wrote: > Hi, > > I am interested in adding AMQP notifications to the Horizon dashboard, > as described in the following blueprint: > https://blueprints.launchpad.net/horizon/+spec/horizon-notifications > > There are currently several implementations in Openstack. While > Nova and Cinder define `notify_about_*` methods that are called > whenever a notification has to be sent, Keystone uses decorators, > which send appropriate notifications when decorated methods are > called. > > I fed the blueprint's whiteboard with an implementation proposal, > based on Nova and Cinder implementation. I would be interested in > having your opinion about which method would fit best, and whether > these notifications make sense at all. > > Cheers, > Florent Flament > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
