Hi Chris, I rebased the patches again. And added realistic data to tests. https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-api-support,n,z Thanks!
From: Christopher Yeoh [mailto:cbky...@gmail.com] Sent: Monday, November 11, 2013 4:43 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] Request for review ( PCI passthrough API) Hi Tian, A couple of things that came out of the V3 API discussions which are relevant to your patches: - In Icehouse we want to merge the V3 API version of patches either before the V2 one or in the same patch. With yours split its probably easiest to do that by setting the V2 patches dependent on the V3 ones. - I've added this previously in the review comments for some of the patches that we also would like a specification written up for the REST API which you are adding (not just what data is returned, but the methods (GET/POST/PUT/DELETE), URLs, data format in and data format out). At this point in time in the blueprint is probably best approach with a summary in the commit message for the portion which is added (since the API changes are split up - which is good) Regards, Chris On Mon, Nov 11, 2013 at 7:23 PM, Tian, Shuangtai <shuangtai.t...@intel.com<mailto:shuangtai.t...@intel.com>> wrote: Hi,All PCI pass-through support has been added to nova. Now we are doing the apis to support PCI pass-through. Pls review the code :https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-api-support,n,z Thank you very much. Best regards, Tian, Shuangtai _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org<mailto:OpenStack-dev@lists.openstack.org> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
