Hi Illia,
You're correct; until the work on establishing datastore types and versions as
a first class Trove concept is finished, which will hopefully be soon (see
Andrey Shestakov's pull request), testing non-MySQL datastore types will be
problematic.
A short term, fake-mode only solution could be accomplished fairly quickly as
follows: run the fake mode tests a third time in Tox with a new configuration
which allows for MongoDB.
If you look at tox.ini, you'll see that the integration tests run in fake mode
twice already:
>> {envpython} run_tests.py
>> {envpython} run_tests.py --test-config=etc/tests/xml.localhost.test.conf
The second invocation causes the trove-client to be used in XML mode,
effectively testing the XML client.
(Tangent: currently running the tests twice takes some time, even in fake mode-
however it will cost far less time once the following pull request is merged:
https://review.openstack.org/#/c/52490/)
If you look at run_tests.py, you'll see that on line 104 it accepts a trove
config file. If the run_tests.py script is updated to allow this value to be
specified optionally via the command line, you could create a variation on
"etc/trove/trove.conf.test" which specifies MongoDB. You'd then invoke
run_tests.py with a "--group=" argument to run some subset of the tests support
by the current Mongo DB code in fake mode.
Of course, this will do nothing to test the guest agent changes or confirm that
the end to end system actually works, but it could help test a lot of
incidental API and infrastructure database code.
As for real mode tests, I think we should wait until the datastore type /
version code is finished, at which point I know we'll all be eager to add
additional tests for these new datastores. Of course in the short term it
should be possible for you to change the code locally to build a Mongo DB image
as well as a Trove config file to support this and then just run some subset of
tests that works with Mongo.
Thanks,
Tim
________________________________
From: Illia Khudoshyn [ikhudos...@mirantis.com]
Sent: Monday, October 21, 2013 9:42 AM
To: OpenStack Development Mailing List
Subject: [openstack-dev] [Trove] Testing of new service types support
Hi all,
I've done with implementing the very first bits of MongoDB support in Trove
along with unit tests and faced an issue with proper testing of it.
It is well known that right now only one service type per installation is
supported by Trove (it is set in config). All testing infrastructure, including
Trove-integration codebase and jenkins jobs, seem to rely on that service type
as well. So it seems to be impossible to run all existing tests AND some
additional tests for MongoDB service type in one pass, at least until Trove
client will allow to pass service type (I know that there is ongoing work in
this area).
Please note, that all of the above is about functional and intergation testing
-- there is no issues with unit tests.
So the question is, should I first submit the code to Trove and then proceed
with updating Trove-integration or just put aside all that MongoDB stuff until
client (and -integration) will be ready?
PS AFAIK, there is some work on adding Cassandra and Riak (or Redis?) support
to Trove. These guys will likely face this issue as well.
--
Best regards,
Illia Khudoshyn,
Software Engineer, Mirantis, Inc.
38, Lenina ave. Kharkov, Ukraine
www.mirantis.com<http://www.mirantis.ru/>
www.mirantis.ru<http://www.mirantis.ru/>
Skype: gluke_work
ikhudos...@mirantis.com<mailto:ikhudos...@mirantis.com>
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
