On Mon, Sep 23, 2013 at 10:56 PM, Russell Bryant <rbry...@redhat.com> wrote:
> On 09/21/2013 12:02 AM, Pádraig Brady wrote: > > On 09/20/2013 10:47 PM, Michael Still wrote: > >> Before https://review.openstack.org/#/c/46867/ if file injection of a > >> mandatory file fails, nova just silently ignores the failure, which is > >> clearly wrong. > > > > For reference, the original code you're adjusting is > > https://review.openstack.org/#/c/18900 > > BTW, I'm not sure of your adjustments but that's beside the point > > and best left for discussion at the above review. > > > >> However, that review now can't land because its > >> revealed another failure in the file injection code via tempest, which > >> is... > >> > >> Should file injection work for instances which are boot from volume? > > > > For consistency probably yes. > > > >> Now that we actually notice injection failures we're now failing to > >> boot such instances as file injection for them doesn't work. > >> > >> I'm undecided though -- should file injection work for boot from > >> volume at all? Or should we just skip file injection for instances > >> like this? I'd prefer to see us just support config drive and metadata > >> server for these instances, but perhaps I am missing something really > >> important. > > > > Now I wouldn't put too much effort into new file injection mechanisms, > > but in this case it might be easy enough to support injection to volumes. > > In fact there was already an attempt made at: > > https://review.openstack.org/#/c/33221/ > > I agree with Monty and Thierry that ideally file injection should DIAF > everywhere. On that note, have we done anything with that in the v3 > API? I propose we remove it completely. > It was separated from core as the os-personalities extension. So its very easy to drop completely from the V3 API if we want to. Do you want me to submit a changeset do do this now (given the feature freeze) or wait until icehouse? Regards, Chris
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
