Based on an intial run of the Hyper-V Nova tests with pymox (https://github.com/emonty/pymox), only 2 of the tests required some minor adjustements while the rest was running perfectly fine by just replacing the mox import line.
If we plan to support pymox in Havana, I'd be happy to send a patch for review with those fixes. Alessandro On Jul 27, 2013, at 02:12 , Joe Gordon <joe.gord...@gmail.com<mailto:joe.gord...@gmail.com>> wrote: On Jul 26, 2013 5:53 AM, "Russell Bryant" <rbry...@redhat.com<mailto:rbry...@redhat.com>> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 07/26/2013 05:35 AM, Roman Bogorodskiy wrote: > > Alex Meade wrote: > > > >> +1 to everything Russell just said and of course Blueprints for > >> this. One for #3 (changing from mox -> Mock) would be good so > >> that anyone who is bored or finds this urgent can collaborate. > >> Also, we need to make sure reviewers are aware (Hopefully they > >> are reading this). > >> > >> -Alex > > > > I have created a blueprint for Nova: > > > > https://blueprints.launchpad.net/nova/+spec/mox-to-mock-conversion > > > > Our team has some spare cycles, so we can work on that. > > Is this really worth it? The original post identified pymox as > compatible with mox and Python 3 compatible. If that's the case, > making a specific effort to convert everything doesn't seem very > valuable. The downsides are risk of changing test behavior and > unnecessary burden on the review queue. > ++ > If a test needs to be changed anyway, then that seems like an > opportunistic time to go ahead and rewrite it. > > If you have spare cycles, I can probably help find something more > valuable to work on. Feel free to come talk to me. I'd choose most > of the open bugs over this, for example. There are hundreds of them > to choose from. :-) > > - -- > Russell Bryant > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.13 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlHycHkACgkQFg9ft4s9SAYyTQCfY9lKmr6CHNEPb1q0suRBGU/M > FA0AnR5fJBBG8AsOTX1aIoT845ru3hvH > =Bpbo > -----END PGP SIGNATURE----- > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org<mailto:OpenStack-dev@lists.openstack.org> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org<mailto:OpenStack-dev@lists.openstack.org> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
