On 08/02/2013 01:23 AM, Christopher Yeoh wrote:
Hi,
Matthew Trenish brought up an issue on one of the proposed Nova V3 API
tempest tests:
> So I get why you do things this way. But, unlike nova we aren't
going to be able to do part1
> being a straight copy and paste. Doing so will double the amount of
times we run these tests in
> the gate once this gets merged. I think it would be best to go about
this as smaller patches in a
> longer series, just adding the v3 tests, instead of copying and
pasting. But, that has it's own
> tradeoffs too. I think you should probably bring this up on the
mailing list to get other opinions
> on how to go about adding the v3 tests. I feel that this needs a
wider discussion.
I think that the part 1/part 2 approach is the best way to go for the
tempest tests. For the Nova changes we had a policy of reviewing, but
not approving the part 1 patch until the part 2 patch had been
approved. So there is no extra gate load until its ready for v3.
Chris, I think there is some background missing on exactly what this
part 1/part 2 approach is. I can imagine some things but it would be
better if you just gave a brief description of what you did in the nova
code.
I think its much easier to review when you only need to look at the v2
vs v3 changes rather than see it as brand new code. Looking at it as
brand new code does have an advantage in that sometimes bugs are
picked up in the old code, but its a *lot* more effort for the
reviewers even if the patch is split up into many parts.
Yes it is, especially when many of the reviewers will never have used
the v3 api or know a lot about it. And I think the current v2 nova
tempest tests are about 7500 lines of code right now.
As for the extra gate load, the extra v3 tests are an issue longer
term but I think we're hoping the parallelisation work is going to
save us :-)
Well it will have to. As long as trunk is supporting v2 and v3 we have
to run both I think.
-David
_______________________________________________
OpenStack-dev mailing list
[email protected]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
