https://bugzilla.mindrot.org/show_bug.cgi?id=3049

--- Comment #7 from Darren Tucker <[email protected]> ---
I don't think the retries are worth it in this context either.  I'm not
sure it's even possible for an FD to change under it, but if so this
could be handled by the fallback.

Also noticed this warning this because "got" gets promoted:

bsd-closefrom.c:132:16: warning: comparison of integers of different
signs:
      'int' and 'unsigned long' [-Wsign-compare]
        for (i = 0; i < got / PROC_PIDLISTFD_SIZE; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
$ grep -r PROC_PIDLISTFD_SIZE /usr/include
/usr/include//sys/proc_info.h:#define PROC_PIDLISTFD_SIZE              
(sizeof(struct proc_fdinfo))

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
[email protected]
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

Reply via email to