----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/592/#review1241 -----------------------------------------------------------
I think the warning message should either go, or be modified to warn only once, or be changed to lldebug... the way it is now it floods the logfiles... i have 1900 repeats of that warning line in my log file, after being logged in for less than 5 minutes! - Lance Corrimal On July 25, 2012, 3:12 p.m., Ansariel Hiller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/592/ > ----------------------------------------------------------- > > (Updated July 25, 2012, 3:12 p.m.) > > > Review request for Viewer. > > > Description > ------- > > A proposed solution for STORM-1899 and the issue, where the handpose of > avatars randomly get stuck in the spread hand position. > > In the current implementation, this case might happen under the following > circumstances: > * Avatar uses an animation with hand pose A > * A request is issued to change hand pose to B > * Before the viewer has blended pose A over to pose B, the original pose A is > requested again > * In this case, the hand pose will not be properly (re)set and because > mNewPose == mCurrentPose, there will be no further blending, leaving the hand > in it's current pose > > The patch will properly reset the hand pose in this case and update the > visual parameters of the avatar. > > > This addresses bug STORM-1899. > https://jira.secondlife.com/browse/STORM-1899 > > > Diffs > ----- > > indra/llcharacter/llhandmotion.cpp 4d9106153407 > > Diff: http://codereview.secondlife.com/r/592/diff/diff > > > Testing > ------- > > > Thanks, > > Ansariel Hiller > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
