----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/524/#review1122 -----------------------------------------------------------
indra/newview/llimview.cpp <http://codereview.secondlife.com/r/524/#comment1094> Warning level should be used for potential code or protocol problems. This would be better at Info level. indra/newview/llimview.cpp <http://codereview.secondlife.com/r/524/#comment1096> Doesn't it make more sense to put the isMuted check in an outer test, and then the more specific additional checks for voice in the inner check? Also, why is isLinden a special case for voice but not for other sessions? indra/newview/llimview.cpp <http://codereview.secondlife.com/r/524/#comment1095> Info level - Oz Linden On Dec. 12, 2011, 6 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/524/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2011, 6 a.m.) > > > Review request for Viewer. > > > Description > ------- > > Ad-hoc IMs and voice call sessions are established even though you have muted > the initiator. The result is that others in the ad-hoc session start writing > back to what is usually some provocative message from the initiator and you > end up seeing these messages. It has been reported that many IM tabs are > also created sometimes. > > > This addresses bug STORM-1731. > http://jira.secondlife.com/browse/STORM-1731 > > > Diffs > ----- > > doc/contributions.txt f9a1f62ac997 > indra/newview/llimview.cpp f9a1f62ac997 > > Diff: http://codereview.secondlife.com/r/524/diff/diff > > > Testing > ------- > > See test plan in jira. > > Testing Not Done: regression testing to see if these code changes have broken > muting for other circumstances. > > > Thanks, > > Jonathan Yap > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
