----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/#review723 -----------------------------------------------------------
Ship it! indra/newview/llassetuploadresponders.cpp <http://codereview.secondlife.com/r/323/#comment690> No objections, so let's just see whether this works. It'd be nice if whoever did change this from 'mPostData' to 'content' would comment on this fix, but as the commit where that happened seems to lump together many unrelated changes (maybe still from an SVN branch?), it'll be difficult to track down who that even was. - Boroondas On June 5, 2011, 8:11 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/323/ > ----------------------------------------------------------- > > (Updated June 5, 2011, 8:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Something in the big mesh branch merge (build 230088) appears to have broken > bulk uploading. > > * On inventory tab, click "+" menu -> Upload -> Set Default Permissions > * Set your default permissions to enable Next owner Modify, Copy, and > Resell/Giveaway and click OK > * Click "+" menu -> Upload -> Bulk and select a group of multiple images > * After upload completes, check permissions of each uploaded item > > Expected behavior is that all the bulk uploaded items would have > Modify/Copy/Transfer permissions. > Actual results is that first item upload has Modify/Copy/Transfer > permissions, all others have no perms at all. > > I examined this area of code before the mesh merge and saw a small but > significant difference. It is not clear to me that this is the only change > necessary; in an email Oz said a server-side change might be needed too. > > > This addresses bug VWR-25896. > http://jira.secondlife.com/browse/VWR-25896 > > > Diffs > ----- > > doc/contributions.txt e4ef43d63d55 > indra/newview/llassetuploadresponders.cpp e4ef43d63d55 > > Diff: http://codereview.secondlife.com/r/323/diff > > > Testing > ------- > > Repeated bulk uploading of two textures, altering the settings in the bulk > upload floater for each test; their uploaded properties followed the settings > I had set in the floater. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
