----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/322/#review717 -----------------------------------------------------------
autobuild.xml <http://codereview.secondlife.com/r/322/#comment683> I don't think the LL viewer should use library binaries not hosted under LL's control. indra/llndof-linux/ndofdev.c <http://codereview.secondlife.com/r/322/#comment684> You are replacing the prebuilt installable AND adding the lib sources to the viewer source tree? That can't be the right way, sorry. - Boroondas On June 3, 2011, 6:10 p.m., Altair Memo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/322/ > ----------------------------------------------------------- > > (Updated June 3, 2011, 6:10 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > fix for OPEN-21 > added EVDEV layer for linux users on 2.6.35+ kernels > > - added both personal 3P libs and indra subdir (and cmake NDOF.cmake file > fix), first one less usefull, should be more better find a place where put > prebuilt lib (jira affect only linux) > > > This addresses bug OPEN-21. > http://jira.secondlife.com/browse/OPEN-21 > > > Diffs > ----- > > autobuild.xml d74fd886c8a6 > doc/contributions.txt d74fd886c8a6 > indra/cmake/NDOF.cmake d74fd886c8a6 > indra/llndof-linux/CMakeLists.txt PRE-CREATION > indra/llndof-linux/Makefile PRE-CREATION > indra/llndof-linux/ndofdev.c PRE-CREATION > indra/llndof-linux/ndofdev_external.h PRE-CREATION > > Diff: http://codereview.secondlife.com/r/322/diff > > > Testing > ------- > > I suppose "on my linux system work" is a poor point, using prebuilt òlibs > since long, the cmake and subdir work using autobuild with "ReleaseOS" > > > Thanks, > > Altair > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
