----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review523 -----------------------------------------------------------
indra/llui/lllineeditor.h <http://codereview.secondlife.com/r/244/#comment413> Any reason why ... indra/llui/lllineeditor.cpp <http://codereview.secondlife.com/r/244/#comment412> ... this simple setter isn't implemented right at the declaration (i.e. in indra/llui/lllineeditor.h)? indra/newview/llbottomtray.cpp <http://codereview.secondlife.com/r/244/#comment414> If font isn't used later, this could be written as mNearbyChatBar->getChatBox()->setFont(LLViewerChat::getChatFont()); (Not sure which variant is more readable.) indra/newview/llnearbychatbar.cpp <http://codereview.secondlife.com/r/244/#comment415> Put some punctuation between "font" and "whohoo" :-P indra/newview/llviewerchat.cpp <http://codereview.secondlife.com/r/244/#comment416> Whatever the reason for that comment is, I guess the idea is that you put new members below it, not above. Also, should this be initialized to null here ... indra/newview/llviewerchat.cpp <http://codereview.secondlife.com/r/244/#comment417> ... so that it actually will be null here the first time? - Boroondas On March 30, 2011, 5:43 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/244/ > ----------------------------------------------------------- > > (Updated March 30, 2011, 5:43 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Chat preferences > font size should increase size of input text in the chat > box > > > This addresses bug STORM-1095. > http://jira.secondlife.com/browse/STORM-1095 > > > Diffs > ----- > > doc/contributions.txt 65ff7415f171 > indra/llui/lllineeditor.h 65ff7415f171 > indra/llui/lllineeditor.cpp 65ff7415f171 > indra/newview/llbottomtray.cpp 65ff7415f171 > indra/newview/llfloaterpreference.cpp 65ff7415f171 > indra/newview/llnearbychatbar.h 65ff7415f171 > indra/newview/llnearbychatbar.cpp 65ff7415f171 > indra/newview/llviewerchat.h 65ff7415f171 > indra/newview/llviewerchat.cpp 65ff7415f171 > > Diff: http://codereview.secondlife.com/r/244/diff > > > Testing > ------- > > Change font size in preferences and see > 1) Font size in chat input box changes to new size immediately > 2) Font size is set to selected size when viewer is restarted > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
