-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/142/
-----------------------------------------------------------
(Updated Feb. 8, 2011, 5:22 a.m.)
Review request for Viewer.
Changes
-------
Took out the changes to flip the down-arrow in the bottom right of the Landmark
panel to an up-arrow when it is pushed as that change is not within the scope
of this jira.
Summary
-------
Please see the jira for the referenced pictures.
In picture #1, in the preferences > graphics > hardware settings, the line of
"gamma" setting is a little too up and it collides with the "antialiasing" line.
In picture #2 in the "places" tab under "my landmarks" tab the "profile" button
gets cut off at the end from the rest of the sidebar's UI.
There are a number of other buttons with alignment issues with no screenshot.
In picture #3 in the Access tab in the About Land window, the remove buttons
are off to the right a few millimetres.
Changes made were to align the Hardware Settings and About Land buttons and to
completely go over the buttons in the Landmarks panel. The small down-arrow at
the bottom right corner was using an imbedded UTF-8 so I fixed that and also
made it point up while the menu is open (there is a separate jira for reversing
the direction it points in these two states).
This patch really needs a test viewer built to make sure all works and that
nothing was missed in the Landmarks panel. There are 3 other related jiras
that I hope are taken in; a test viewer could be made incorporating all 4 jiras
at that point.
This addresses bug STORM-974.
http://jira.secondlife.com/browse/STORM-974
Diffs (updated)
-----
indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090
Diff: http://codereview.secondlife.com/r/142/diff
Testing
-------
Thanks,
Jonathan
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
