----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/122/#review251 -----------------------------------------------------------
I'm not a Windows person, but ... indra/llcommon/llpreprocessor.h <http://codereview.secondlife.com/r/122/#comment183> Isn't the 'pop' sufficient for restoring the previous warning settings? What purpose do the 'disable', 'push' and 'default' after that serve? See also OlafvdSpek's comment about the proposed workaround on the page you linked. - Boroondas On Jan. 25, 2011, 11:12 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/122/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2011, 11:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Correct marco redefinition warnings introduced in Visual Studio 10. Patch > applies workaround documented at: > http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings > > Depends on vwr-24610 which should be applied first. > > > This addresses bug vwr-24612. > http://jira.secondlife.com/browse/vwr-24612 > > > Diffs > ----- > > indra/llcommon/llpreprocessor.h 26c09ad4293e > > Diff: http://codereview.secondlife.com/r/122/diff > > > Testing > ------- > > Before (snip) > 1>C:\Program Files (x86)\Microsoft Visual Studio > 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition > 1> indra.l.cpp(85) : see previous definition of 'UINT32_MAX' > ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ========== > After patch applied: > 1>------ Build started: Project: lscript_compile, Configuration: Release > Win32 ------ > 1> lscript_bytecode.cpp > 1> lscript_error.cpp > 1> lscript_resource.cpp > 1> lscript_scope.cpp > 1> lscript_tree.cpp > 1> lscript_typecheck.cpp > 1> indra.y.cpp > 1> indra.l.cpp > 1> lscript_compile.vcxproj -> > C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib > ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== > > > Thanks, > > Nicky > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
